Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3764)

Unified Diff: chrome/common/page_action.h

Issue 246037: Integrate browser actions with the wrench menu. Browser actions (Closed)
Patch Set: alphabetize Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/page_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/page_action.h
diff --git a/chrome/common/page_action.h b/chrome/common/page_action.h
index 8594ace78be8e505cf43198c4acdf3471c83736e..cb3a72f445f9b30eb7cff04ab1ef68d58292f5bf 100644
--- a/chrome/common/page_action.h
+++ b/chrome/common/page_action.h
@@ -21,6 +21,8 @@ class ContextualAction {
BROWSER_ACTION = 1,
} ContextualActionType;
+ int command_id() const { return command_id_; }
+
std::string id() const { return id_; }
void set_id(const std::string& id) { id_ = id; }
@@ -41,6 +43,8 @@ class ContextualAction {
}
private:
+ static int next_command_id_;
+
// The id for the ContextualAction, for example: "RssPageAction".
// For BrowserActions this is blank.
std::string id_;
@@ -57,6 +61,10 @@ class ContextualAction {
// The paths to the icons that this PageIcon can show.
std::vector<std::string> icon_paths_;
+
+ // An integer for use with the browser's command system. These should always
+ // be in the range [IDC_BROWSER_ACTION_FIRST, IDC_BROWSER_ACTION_LAST].
+ int command_id_;
};
typedef std::map<std::string, ContextualAction*> ContextualActionMap;
« no previous file with comments | « chrome/common/extensions/extension.cc ('k') | chrome/common/page_action.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698