Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 246004: Remove the context menu item 'Remove from list' from download shelf (Closed)

Created:
11 years, 3 months ago by Mohamed Mansour
Modified:
9 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Remove the context menu item 'Remove from shelf' from download shelf BUG=23078 TEST=No more menu item on download item Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27312

Patch Set 1 #

Patch Set 2 : Removed download item menu resource #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M chrome/app/generated_resources.grd View 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/download_shelf.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_shelf.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Mohamed Mansour
11 years, 3 months ago (2009-09-25 18:30:04 UTC) #1
Nico
Looks good, but since this removes REMOVE_ITEM from download_shelf.h/cc , you have to wait with ...
11 years, 3 months ago (2009-09-25 18:41:46 UTC) #2
Nico
Jeremy pointed out in the review of the os x part that IDS_DOWNLOAD_MENU_REMOVE_ITEM is now ...
11 years, 3 months ago (2009-09-25 23:39:41 UTC) #3
Nico
On 2009/09/25 23:39:41, Nico wrote: > Jeremy pointed out in the review of the os ...
11 years, 3 months ago (2009-09-26 00:12:53 UTC) #4
Mohamed Mansour
I added IDS_DOWNLOAD_MENU_REMOVE_ITEM, safe to commit now?
11 years, 3 months ago (2009-09-26 00:44:20 UTC) #5
Nico
11 years, 3 months ago (2009-09-26 00:55:48 UTC) #6
LG, assuming you tried it locally and it passes trybots etc. Thanks! :-)

Powered by Google App Engine
This is Rietveld 408576698