Issue 2458002: Initialize screen locker before letting user logged in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2458002: Initialize screen locker before letting user logged in. (Closed)

Created:
10 years, 6 months ago by oshima

Modified:
9 years, 6 months ago

Reviewers:
davidjames, David James

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Initialize screen locker before letting user logged in. Retry up to 30 seconds (1 sec x 30) even if it fails to grab inputs. BUG=none TEST=manual: scree lock should work after chrome crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48776

Patch Set 1 #

Patch Set 2 : retry grab inputs #

Patch Set 3 : don't fail when receiving lock screen more than twice.(for now) #

Patch Set 4 : " #

Patch Set 5 : fix login_browsertest #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -18 lines)			Patch
M	chrome/browser/browser_main.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_browsertest.cc	View		5 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/screen_locker.cc	View	2 3	5 chunks	+65 lines, -16 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

oshima

I uploaded another patch that fixes an issue with login browser test. Could you please ...

10 years, 6 months ago (2010-06-02 19:04:43 UTC) #5

LGTM

Expand Messages | Collapse Messages