Add Chewing integer preferences

Add Chewing integer preferences

BUG=chromium-os:2624
TEST=Open the IME settings window. Add Traditional Chinese. Open the options dialog, and check that the integer prefs are there

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48806

[Yusuke Sato, 2010-06-01 10:18:48]

http://codereview.chromium.org/2457001/diff/2001/3003
File chrome/browser/chromeos/options/language_chewing_config_view.cc (right):

http://codereview.chromium.org/2457001/diff/2001/3003#newcode163
chrome/browser/chromeos/options/language_chewing_config_view.cc:163: unsigned
int pref_id;
please use size_t to be consistent with other functions.

http://codereview.chromium.org/2457001/diff/2001/3003#newcode249
chrome/browser/chromeos/options/language_chewing_config_view.cc:249:
NotifyPrefChanged();
I'm not so sure but I guess NotifyPrefChanged() has to be called before calling
AddView(combobox)?

Otherwise, LanguageChewingConfigView::ItemChanged() might be called with an
unexpected argument (|new_index| == 0).

http://codereview.chromium.org/2457001/diff/2001/3004
File chrome/browser/chromeos/options/language_chewing_config_view.h (right):

http://codereview.chromium.org/2457001/diff/2001/3004#newcode16
chrome/browser/chromeos/options/language_chewing_config_view.h:16: #include
"views/controls/slider/slider.h"
please sort alphabetically

[Zachary Kuznia, 2010-06-02 02:46:52]

http://codereview.chromium.org/2457001/diff/2001/3003
File chrome/browser/chromeos/options/language_chewing_config_view.cc (right):

http://codereview.chromium.org/2457001/diff/2001/3003#newcode163
chrome/browser/chromeos/options/language_chewing_config_view.cc:163: unsigned
int pref_id;
On 2010/06/01 10:18:48, Yusuke Sato wrote:
> please use size_t to be consistent with other functions.

Done.

http://codereview.chromium.org/2457001/diff/2001/3003#newcode249
chrome/browser/chromeos/options/language_chewing_config_view.cc:249:
NotifyPrefChanged();
Moved before the combo boxes.  It needs to be called after the sliders are
added, however, because they lose their value otherwise.

On 2010/06/01 10:18:48, Yusuke Sato wrote:
> I'm not so sure but I guess NotifyPrefChanged() has to be called before
calling
> AddView(combobox)?
> 
> Otherwise, LanguageChewingConfigView::ItemChanged() might be called with an
> unexpected argument (|new_index| == 0).
>

http://codereview.chromium.org/2457001/diff/2001/3004
File chrome/browser/chromeos/options/language_chewing_config_view.h (right):

http://codereview.chromium.org/2457001/diff/2001/3004#newcode16
chrome/browser/chromeos/options/language_chewing_config_view.h:16: #include
"views/controls/slider/slider.h"
Fixed.

On 2010/06/01 10:18:48, Yusuke Sato wrote:
> please sort alphabetically

[Yusuke Sato, 2010-06-02 04:29:51]

LGTM, thanks!