Issue 2454001: Fix an occasional crash in Assembler::ldr() for arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2454001: Fix an occasional crash in Assembler::ldr() for arm. (Closed)

Created:
10 years, 6 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko, Mads Ager (chromium)

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git

Visibility:
Public.

Description

Fix an occasional crash in Assembler::ldr() for arm. A peephole optimization can be attempted on a buffer that contains only a single command. The crash happens when running debug on Snow Leopard with --simulator=arm. Committed: http://code.google.com/p/v8/source/detail?r=4762

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix long line #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -25 lines)			Patch
	M	src/arm/assembler-arm.cc	View	1	1 chunk	+26 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM! http://codereview.chromium.org/2454001/diff/1/2 File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/2454001/diff/1/2#newcode1232 src/arm/assembler-arm.cc:1232: PrintF("%x push/pop (diff reg) replaced by a reg ...

10 years, 6 months ago (2010-06-01 07:51:35 UTC) #2

Vitaly Repeshko

10 years, 6 months ago (2010-06-01 07:53:36 UTC) #3

LGTM.

http://codereview.chromium.org/2454001/diff/1/2
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/2454001/diff/1/2#newcode1232
src/arm/assembler-arm.cc:1232: PrintF("%x push/pop (diff reg) replaced by a reg
move\n", pc_offset());
nit: long line.

Expand Messages | Collapse Messages