Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2454001: Fix an occasional crash in Assembler::ldr() for arm. (Closed)

Created:
10 years, 6 months ago by Dmitry Titov
Modified:
9 years, 7 months ago
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git
Visibility:
Public.

Description

Fix an occasional crash in Assembler::ldr() for arm. A peephole optimization can be attempted on a buffer that contains only a single command. The crash happens when running debug on Snow Leopard with --simulator=arm. Committed: http://code.google.com/p/v8/source/detail?r=4762

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix long line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -25 lines) Patch
M src/arm/assembler-arm.cc View 1 1 chunk +26 lines, -25 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Titov
10 years, 6 months ago (2010-06-01 07:33:18 UTC) #1
Mads Ager (chromium)
LGTM! http://codereview.chromium.org/2454001/diff/1/2 File src/arm/assembler-arm.cc (right): http://codereview.chromium.org/2454001/diff/1/2#newcode1232 src/arm/assembler-arm.cc:1232: PrintF("%x push/pop (diff reg) replaced by a reg ...
10 years, 6 months ago (2010-06-01 07:51:35 UTC) #2
Vitaly Repeshko
10 years, 6 months ago (2010-06-01 07:53:36 UTC) #3
LGTM.

http://codereview.chromium.org/2454001/diff/1/2
File src/arm/assembler-arm.cc (right):

http://codereview.chromium.org/2454001/diff/1/2#newcode1232
src/arm/assembler-arm.cc:1232: PrintF("%x push/pop (diff reg) replaced by a reg
move\n", pc_offset());
nit: long line.

Powered by Google App Engine
This is Rietveld 408576698