Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2452007: Fix bug that could cause a string to be incorrectly tagged as an array index. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug that could cause a string to be incorrectly tagged as an array index. We should only mark a string as an array index if we can store the entire value of the number in the hash field. We sometimes failed to reject larger numbers. Fixes http://code.google.com/p/v8/issues/detail?id=728

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M src/objects-inl.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +47 lines, -0 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
10 years, 6 months ago (2010-06-02 09:24:22 UTC) #1
Søren Thygesen Gjesse
10 years, 6 months ago (2010-06-02 09:27:03 UTC) #2
LGTM

http://codereview.chromium.org/2452007/diff/1/3
File test/cctest/test-strings.cc (right):

http://codereview.chromium.org/2452007/diff/1/3#newcode439
test/cctest/test-strings.cc:439: // We incorrectly allowed strings to be tagged
as array indices even if their
Maybe open a bug and refer to it here.

Powered by Google App Engine
This is Rietveld 408576698