Issue 2451002: Prevent Client::Tick() from causing reentrancy in the plugin on Mac OS X....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2451002: Prevent Client::Tick() from causing reentrancy in the plugin on Mac OS X.... (Closed)

Created:
10 years, 6 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
mafv

CC:
o3d-review_googlegroups.com, Tristan Schmelcher 2

Base URL:
svn://svn.chromium.org/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Prevent Client::Tick() from causing reentrancy in the plugin on Mac OS X. Tested with client application. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48770

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -3 lines)			Patch
M	core/cross/client.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	core/cross/client.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	plugin/mac/plugin_mac.mm	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mafv

LGTM but needs testing on Firefox, Safari and Chrome before we ship.

10 years, 6 months ago (2010-06-02 21:38:47 UTC) #2

Ken Russell (switch to Gerrit)

10 years, 6 months ago (2010-06-02 21:45:56 UTC) #3

On 2010/06/02 21:38:47, mafv wrote:
> LGTM but needs testing on Firefox, Safari and Chrome before we ship.

Just tested on Firefox 3.6.3 and Safari 4 (64-bit mode) on 10.6; both are
working. Will test on 10.5 after checkin.

Expand Messages | Collapse Messages