Issue 245042: Remove CallEval as a subclass of the Call AST node type. We were not...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245042: Remove CallEval as a subclass of the Call AST node type. We were not... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove CallEval as a subclass of the Call AST node type. We were not differentiating between Call and CallEval except in the code generator, and the difference can be detected from a regular Call AST node at code generation time. Committed: http://code.google.com/p/v8/source/detail?r=2984

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+178 lines, -254 lines)			Patch
M	src/arm/codegen-arm.cc	View	3 chunks	+51 lines, -59 lines	0 comments	Download
M	src/ast.h	View	2 chunks	+0 lines, -19 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cfg.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	3 chunks	+58 lines, -60 lines	0 comments	Download
M	src/parser.cc	View	4 chunks	+1 line, -21 lines	0 comments	Download
M	src/prettyprinter.cc	View	2 chunks	+0 lines, -10 lines	0 comments	Download
M	src/rewriter.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	src/usage-analyzer.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/variables.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/x64/codegen-x64.cc	View	5 chunks	+61 lines, -60 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages