Issue 245019: Fix comments in test expectations. Also, the description in my previous...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245019: Fix comments in test expectations. Also, the description in my previous... (Closed)

Created:
11 years, 2 months ago by Dirk Pranke

Modified:
9 years, 7 months ago

Reviewers:
ojan

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix comments in test expectations. Also, the description in my previous change to this file was wrong, the new values for expectations are 'TEXT', 'IMAGE', and 'IMAGE+TEXT' ('BOTH' is not a valid value). R=ojan BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27310

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		2 chunks	+25 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Ojan, can you take a look at this - minor change to update the comments ...

11 years, 2 months ago (2009-09-26 01:03:20 UTC) #1

LGTM

Expand Messages | Collapse Messages