Issue 245008: Add an additional test for dnsDomainIs() to verify that it doesn't simply mat...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 245008: Add an additional test for dnsDomainIs() to verify that it doesn't simply mat... (Closed)

Created:
11 years, 3 months ago by eroman

Modified:
9 years, 6 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, darin (slow to review), tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add an additional test for dnsDomainIs() to verify that it doesn't simply match any substring. This is working correctly, but since it was failing in WinHTTP we should have a regression test. BUG=18511

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	net/data/proxy_resolver_v8_unittest/pac_library_unittest.js	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!  Merci.

Expand Messages | Collapse Messages