Chromium Code Reviews

Issue 2446001: Fix smoke tests on Windows. (Closed)

Created:
10 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Fix multiple tests on Windows. BUG=23328 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48613

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+194 lines, -129 lines)
M tests/fake_repos.py View 6 chunks +74 lines, -8 lines 2 comments
M tests/gclient_smoketest.py View 26 chunks +117 lines, -119 lines 0 comments
M tests/presubmit_unittest.py View 1 chunk +2 lines, -1 line 0 comments
M tests/trychange_unittest.py View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
M-A Ruel
I broke scm_unittest and gclient_scm_test when I deleted gclient_test, I will fix that in a ...
10 years, 6 months ago (2010-06-01 00:57:00 UTC) #1
bradn
LGTM http://codereview.chromium.org/2446001/diff/5001/1003 File tests/fake_repos.py (right): http://codereview.chromium.org/2446001/diff/5001/1003#newcode81 tests/fake_repos.py:81: if sys.platform.startswith('win'): Pretty sure this is always win32, ...
10 years, 6 months ago (2010-06-01 01:12:04 UTC) #2
M-A Ruel
10 years, 6 months ago (2010-06-01 01:26:27 UTC) #3 
http://codereview.chromium.org/2446001/diff/5001/1003
File tests/fake_repos.py (right):

http://codereview.chromium.org/2446001/diff/5001/1003#newcode81
tests/fake_repos.py:81: if sys.platform.startswith('win'):
On 2010/06/01 01:12:04, bradn wrote:
> Pretty sure this is always win32, but anyways. Did you want to include cygwin
> too?

You are right, it's just a copy-paste from scripts/common/chromium_utils.py

Powered by Google App Engine