Issue 2441006: fix player_x11 playback problem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2441006: fix player_x11 playback problem. (Closed)

Created:
10 years, 6 months ago by jiesun

Modified:
9 years, 7 months ago

Reviewers:
wjia(left Chromium)

CC:
chromium-reviews, Alpha Left Google

Visibility:
Public.

Description

time stamp is not used , therefore the player_x11 hangs. there are also flow control problem. but it is not addressed in this CL. BUG=None. Test=dev board. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48786

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	media/filters/omx_video_decode_engine.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	media/filters/omx_video_decode_engine.cc	View		2 chunks	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wjia(left Chromium)

10 years, 6 months ago (2010-06-02 21:44:38 UTC) #2

LGTM, except the duration for first frame.

http://codereview.chromium.org/2441006/diff/1/2
File media/filters/omx_video_decode_engine.cc (right):

http://codereview.chromium.org/2441006/diff/1/2#newcode230
media/filters/omx_video_decode_engine.cc:230: 
The boundary condition is not clear. The duration for first frame (after
seeking) will be a large number. If "duration" is in use, that will result in
screen freezing. You could set last_pts_ initially to uint(-1), or 0. Then treat
first frame specially.

Expand Messages | Collapse Messages