Move net::HTTPSProber from net_base to net

Move net::HTTPSProber from net_base to net

net::HTTPSProber belongs into the net library, where also it's only user
net::URLRequest is living. This fixes undefined references in net_base caused
by net::HTTPSProber when not linking against net.

BUG=45493
TEST=Building hresolv with the plain ld linker in shared library configuration should not generate undefined references.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48632

[Mattias Nissler (ping if slow), 2010-05-31 18:49:33]

Please review. Only moves code around in order to make libnet_base.so not depend
on libnet.so (which is obviously wrong).

[agl, 2010-05-31 18:58:13]

TBR LGTM

On May 31, 2010 2:49 PM, <mnissler@chromium.org> wrote:
> Reviewers: agl, Jochen Eisinger,
>
> Message:
> Please review. Only moves code around in order to make libnet_base.so not
> depend
> on libnet.so (which is obviously wrong).
>
> Description:
> Move net::HTTPSProber from net_base to net
>
> net::HTTPSProber belongs into the net library, where also it's only user
> net::URLRequest is living. This fixes undefined references in net_base
> caused
> by net::HTTPSProber when not linking against net.
>
> BUG=45493
> TEST=Building hresolv with the plain ld linker in shared library
> configuration
> should not generate undefined references.
>
> Please review this at http://codereview.chromium.org/2441001/show
>
> SVN Base: http://src.chromium.org/git/chromium.git
>
> Affected files:
> M net/net.gyp
> A + net/url_request/https_prober.h
> A + net/url_request/https_prober.cc
> M net/url_request/url_request_http_job.cc
>
>
> Index: net/net.gyp
> diff --git a/net/net.gyp b/net/net.gyp
> index
>
06dc29e7a7d3ecaa610bec7f2bedcd1d4019516a..5682bcb4381662a0fde3d3dc2c6eb3cf1c4840a5

> 100644
> --- a/net/net.gyp
> +++ b/net/net.gyp
> @@ -78,8 +78,6 @@
> 'base/host_resolver_impl.h',
> 'base/host_resolver_proc.cc',
> 'base/host_resolver_proc.h',
> - 'base/https_prober.h',
> - 'base/https_prober.cc',
> 'base/io_buffer.cc',
> 'base/io_buffer.h',
> 'base/keygen_handler.cc',
> @@ -491,6 +489,8 @@
> 'spdy/spdy_stream.cc',
> 'spdy/spdy_stream.h',
> 'spdy/spdy_transaction_factory.h',
> + 'url_request/https_prober.h',
> + 'url_request/https_prober.cc',
> 'url_request/url_request.cc',
> 'url_request/url_request.h',
> 'url_request/url_request_about_job.cc',
> Index: net/url_request/https_prober.cc
> diff --git a/net/base/https_prober.cc b/net/url_request/https_prober.cc
> similarity index 98%
> rename from net/base/https_prober.cc
> rename to net/url_request/https_prober.cc
> index
>
c37f17ddc33b2df277886d63abe020af0b8924ee..a7163ba5b758b71b28705809a5f3e503cbab9005

> 100644
> --- a/net/base/https_prober.cc
> +++ b/net/url_request/https_prober.cc
> @@ -2,7 +2,7 @@
> // Use of this source code is governed by a BSD-style license that can be
> // found in the LICENSE file.
>
> -#include "net/base/https_prober.h"
> +#include "net/url_request/https_prober.h"
>
> #include "net/url_request/url_request.h"
> #include "net/url_request/url_request_context.h"
> Index: net/url_request/https_prober.h
> diff --git a/net/base/https_prober.h b/net/url_request/https_prober.h
> similarity index 100%
> rename from net/base/https_prober.h
> rename to net/url_request/https_prober.h
> Index: net/url_request/url_request_http_job.cc
> diff --git a/net/url_request/url_request_http_job.cc
> b/net/url_request/url_request_http_job.cc
> index
>
c907a6a11dd3e19bf9a46f5528b7dd30d7500873..420100f8f32755aa56c7c8f65b58a4ab9e5126f7

> 100644
> --- a/net/url_request/url_request_http_job.cc
> +++ b/net/url_request/url_request_http_job.cc
> @@ -15,7 +15,6 @@
> #include "net/base/cert_status_flags.h"
> #include "net/base/cookie_policy.h"
> #include "net/base/filter.h"
> -#include "net/base/https_prober.h"
> #include "net/base/transport_security_state.h"
> #include "net/base/load_flags.h"
> #include "net/base/net_errors.h"
> @@ -28,6 +27,7 @@
> #include "net/http/http_transaction.h"
> #include "net/http/http_transaction_factory.h"
> #include "net/http/http_util.h"
> +#include "net/url_request/https_prober.h"
> #include "net/url_request/url_request.h"
> #include "net/url_request/url_request_context.h"
> #include "net/url_request/url_request_error_job.h"
>
>

[jochen (gone - plz use gerrit), 2010-06-01 07:16:51]

lgtm pending trybot happiness