Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 244014: Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin becom... (Closed)

Created:
11 years, 2 months ago by gregoryd
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -507 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
MM base/format_macros.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/app/chrome_dll_main.cc View 2 chunks +0 lines, -3 lines 0 comments Download
D chrome/browser/nacl_process_host.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/browser/nacl_process_host.cc View 1 chunk +0 lines, -187 lines 0 comments Download
M chrome/browser/plugin_service.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/sandbox_policy.cc View 3 chunks +1 line, -7 lines 0 comments Download
M chrome/chrome.gyp View 8 chunks +0 lines, -91 lines 0 comments Download
M chrome/common/child_process_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/common/nacl_messages.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/common/nacl_messages_internal.h View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/common/nacl_types.h View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/common/render_messages_internal.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/common/sandbox_init_wrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_process.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/renderer/render_process.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ipc/ipc_message_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/plugins/plugin_lib.h View 2 chunks +1 line, -3 lines 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 1 chunk +23 lines, -28 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gregoryd
11 years, 2 months ago (2009-09-26 02:21:50 UTC) #1
ncarter (slow)
11 years, 2 months ago (2009-09-26 02:31:21 UTC) #2
This revert LGTM

Powered by Google App Engine
This is Rietveld 408576698