Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: net/ftp/ftp_directory_listing_parsers_unittest.cc

Issue 244008: Beginnings of our own FTP LIST parsing code. (Closed)
Patch Set: test even more (slightly) Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_directory_listing_parsers.cc ('k') | net/net.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_directory_listing_parsers_unittest.cc
diff --git a/net/ftp/ftp_directory_listing_parsers_unittest.cc b/net/ftp/ftp_directory_listing_parsers_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e45968a0307435d6a17d1130892dcb9355d87ccd
--- /dev/null
+++ b/net/ftp/ftp_directory_listing_parsers_unittest.cc
@@ -0,0 +1,93 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/ftp/ftp_directory_listing_parsers.h"
+
+#include "base/string_util.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+struct SingleLineTestData {
+ const char* input;
+ net::FtpDirectoryListingEntry::Type type;
+ const char* filename;
+ int year;
+ int month;
+ int day_of_month;
+ int hour;
+ int minute;
+};
+
+class FtpDirectoryListingParsersTest : public testing::Test {
+ protected:
+ FtpDirectoryListingParsersTest() {
+ }
+
+ void RunSingleLineTestCase(net::FtpDirectoryListingParser* parser,
+ const SingleLineTestData& test_case) {
+ ASSERT_TRUE(parser->ConsumeLine(UTF8ToUTF16(test_case.input)));
+ ASSERT_TRUE(parser->EntryAvailable());
+ net::FtpDirectoryListingEntry entry = parser->PopEntry();
+ EXPECT_EQ(test_case.type, entry.type);
+ EXPECT_EQ(UTF8ToUTF16(test_case.filename), entry.name);
+
+ base::Time::Exploded time_exploded;
+ entry.last_modified.LocalExplode(&time_exploded);
+ EXPECT_EQ(test_case.year, time_exploded.year);
+ EXPECT_EQ(test_case.month, time_exploded.month);
+ EXPECT_EQ(test_case.day_of_month, time_exploded.day_of_month);
+ EXPECT_EQ(test_case.hour, time_exploded.hour);
+ EXPECT_EQ(test_case.minute, time_exploded.minute);
+ EXPECT_EQ(0, time_exploded.second);
+ EXPECT_EQ(0, time_exploded.millisecond);
+ }
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(FtpDirectoryListingParsersTest);
+};
+
+TEST_F(FtpDirectoryListingParsersTest, Ls) {
+ base::Time::Exploded now_exploded;
+ base::Time::Now().LocalExplode(&now_exploded);
+
+ const struct SingleLineTestData good_cases[] = {
+ { "-rw-r--r-- 1 ftp ftp 528 Nov 01 2007 README",
+ net::FtpDirectoryListingEntry::FILE, "README",
+ 2007, 11, 1, 0, 0 },
+ { "drwxr-xr-x 3 ftp ftp 4096 May 15 18:11 directory",
+ net::FtpDirectoryListingEntry::DIRECTORY, "directory",
+ now_exploded.year, 5, 15, 18, 11 },
+ { "lrwxrwxrwx 1 0 0 26 Sep 18 2008 pub -> vol/1/.CLUSTER/var_ftp/pub",
+ net::FtpDirectoryListingEntry::SYMLINK, "pub",
+ 2008, 9, 18, 0, 0 },
+ { "lrwxrwxrwx 1 0 0 3 Oct 12 13:37 mirror -> pub",
+ net::FtpDirectoryListingEntry::SYMLINK, "mirror",
+ now_exploded.year, 10, 12, 13, 37 },
+ };
+ for (size_t i = 0; i < arraysize(good_cases); i++) {
+ SCOPED_TRACE(StringPrintf("Test[%d]: %s", i, good_cases[i]));
+
+ net::FtpLsDirectoryListingParser parser;
+ RunSingleLineTestCase(&parser, good_cases[i]);
+ }
+
+ const char* bad_cases[] = {
+ "",
+ "garbage",
+ "-rw-r--r-- 1 ftp ftp",
+ "-rw-r--rgb 1 ftp ftp 528 Nov 01 2007 README",
+ "-rw-rgbr-- 1 ftp ftp 528 Nov 01 2007 README",
+ "qrwwr--r-- 1 ftp ftp 528 Nov 01 2007 README",
+ "-rw-r--r-- -1 ftp ftp 528 Nov 01 2007 README",
+ "-rw-r--r-- 1 ftp ftp -528 Nov 01 2007 README",
+ "-rw-r--r-- 1 ftp ftp 528 Foo 01 2007 README",
+ };
+ for (size_t i = 0; i < arraysize(bad_cases); i++) {
+ net::FtpLsDirectoryListingParser parser;
+ EXPECT_FALSE(parser.ConsumeLine(UTF8ToUTF16(bad_cases[i]))) << bad_cases[i];
+ }
+}
+
+} // namespace
« no previous file with comments | « net/ftp/ftp_directory_listing_parsers.cc ('k') | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698