Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 244001: Implemented upload progress indicator in status bar.... (Closed)

Created:
11 years, 3 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, ben+cc_chromium.org
Visibility:
Public.

Description

Implemented upload progress indicator in status bar. When sending an HTTP POST request with sufficiently large payload data (such as uploading a file or several), the status bar should display the progress in the form of a percentage. The ResourceDispatcherHost periodically sends upload progress messages to the UI thread as well as to the renderer. If an upload is occurring, other potential LoadStateChanged messages to the same RenderViewHost are ignored; this prevents the upload progress display from being interrupted periodically by "Waiting for <site>" messages. Original code review: http://codereview.chromium.org/211050 Original patch by Simon Radford r=darin BUG=4715 TEST=Try uploading one or more files (e.g. at a file hosting site) and confirm that the percentage is shown in the status bar. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -20 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 6 chunks +46 lines, -12 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 4 chunks +15 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698