Issue 2440005: RootFS size customization params added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2440005: RootFS size customization params added (Closed)

Created:
10 years, 6 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
oshima, Bill Richardson

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Patch Set 3 : added check for rootfs size and its partition #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
M	src/platform/installer/chromeos-common.sh	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/scripts/build_gpt.sh	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	src/scripts/build_image	View	1 2	4 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

oshima

thank you for adding this! looks good, but have one question below. http://codereview.chromium.org/2440005/diff/2001/3003 File src/scripts/build_image ...

10 years, 6 months ago (2010-06-02 15:52:56 UTC) #3

zel

http://codereview.chromium.org/2440005/diff/2001/3003 File src/scripts/build_image (right): http://codereview.chromium.org/2440005/diff/2001/3003#newcode52 src/scripts/build_image:52: "rootfs filesystem size in MBs." On 2010/06/02 15:52:56, oshima ...

10 years, 6 months ago (2010-06-02 17:09:43 UTC) #4

lgtm

thanks!

Expand Messages | Collapse Messages

Issue 2440005: RootFS size customization params added (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : added check for rootfs size and its partition #

Messages