Issue 2440: Now that the V8 changes to SConscript are in trunk, enable...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2440: Now that the V8 changes to SConscript are in trunk, enable... (Closed)

Created:
12 years, 3 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Now that the V8 changes to SConscript are in trunk, enable building V8 under linux by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2077

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -15 lines)			Patch
	M	build/SConscript.main	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	build/SConscript.v8	View	1	1 chunk	+33 lines, -15 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

12 years, 3 months ago (2008-09-11 19:37:34 UTC) #2

Hooray!  LGTM

http://codereview.chromium.org/2440/diff/1/2
File build/SConscript.v8 (right):

http://codereview.chromium.org/2440/diff/1/2#newcode38
Line 38: 'cd ../v8 && $PYTHON $SCONS $SCONSFLAGS snapshot=on sample=shell',
80 chars :~(

Expand Messages | Collapse Messages