Much rearranging of cgptlib. Passes all its (new) unit tests.

Much rearranging of cgptlib.  Passes all its (new) unit tests.

Also includes part of LoadKernel(), which I'll split into a separate
CL.  With some hacks, gets into VerifyKernel() before dying because
I'm not passing in the right key blob.

cgptlib is now pretty stable, and worth looking at.  LoadKernel() less so.

Thanks,
   Randall

[Bill Richardson, 2010-06-02 16:14:57]

I'd prefer a few tweaks, but LGTM once they're made.

http://codereview.chromium.org/2438005/diff/1/3
File src/platform/vboot_reference/tests/cgptlib_test.c (right):

http://codereview.chromium.org/2438005/diff/1/3#newcode35
src/platform/vboot_reference/tests/cgptlib_test.c:35: #define KERNEL_C 2 /*
Overload ROOTFS_A, for some GetNext tests */
We actually have partitions for KERNEL_C and ROOTFS_C. Maybe pick a different
name, so these aren't confused?

http://codereview.chromium.org/2438005/diff/1/6
File src/platform/vboot_reference/utility/Makefile (right):

http://codereview.chromium.org/2438005/diff/1/6#newcode56
src/platform/vboot_reference/utility/Makefile:56:
../vboot_firmware/stub/utility_stub.c $(LIBS) $(FWLIB)
../vboot_firmware/stub/utility_stub.c is already part of $(FWLIB), so this file
isn't needed, and the TODO comment has been done.

http://codereview.chromium.org/2438005/diff/1/16
File src/platform/vboot_reference/vboot_firmware/lib/cgptlib/cgptlib_internal.c
(right):

http://codereview.chromium.org/2438005/diff/1/16#newcode223
src/platform/vboot_reference/vboot_firmware/lib/cgptlib/cgptlib_internal.c:223:
* to check both entries.   To do this, we need to temporarily override
... or we could just compare only the fields we're interested in. I don't like
the idea of modifying things unless we absolutely have to (like CRC
computation).