Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 2438002: CPU profiler: sample call stack on profiling start. (Closed)

Created:
10 years, 6 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

CPU profiler: sample call stack on profiling start. This simplifies writing tests a lot, because it is now possible to guarantee that certain function will present in a profile by starting profiler from inside it. Committed: http://code.google.com/p/v8/source/detail?r=4769

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -13 lines) Patch
M src/cpu-profiler.h View 4 chunks +8 lines, -3 lines 0 comments Download
M src/cpu-profiler.cc View 7 chunks +33 lines, -9 lines 0 comments Download
M src/profile-generator.h View 2 chunks +1 line, -1 line 0 comments Download
M src/unbound-queue.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/unbound-queue-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 2 chunks +107 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 6 months ago (2010-06-01 11:40:06 UTC) #1
Søren Thygesen Gjesse
10 years, 6 months ago (2010-06-01 13:33:33 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698