Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2436006: Add support for selecting candidates via mouseclick. (Closed)

Created:
10 years, 6 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
Yusuke Sato
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/ibus-chewing.git
Visibility:
Public.

Description

Add support for selecting candidates via mouseclick. BUG=chromium-os:3742 TEST=Set your IME to chewing. Type 'ql', press space twice. Click on a candidate.

Patch Set 1 #

Patch Set 2 : Code Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/IBusChewingEngine.gob View 1 3 chunks +22 lines, -0 lines 0 comments Download
M src/IBusChewingEngine-keys.c View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zachary Kuznia
10 years, 6 months ago (2010-06-02 05:29:48 UTC) #1
Yusuke Sato
10 years, 6 months ago (2010-06-02 05:40:00 UTC) #2
LGTM

Can you please upstream this change as well? FYI, Satoru and I usually file a
new issue at http://code.google.com/p/ibus/issues/list and attach a patch to the
issue.

Powered by Google App Engine
This is Rietveld 408576698