Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7026)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/find_bar_host_browsertest.cc

Issue 2433003: Disable FindInPageControllerTest.ActivateLinkNavigatesPage and ... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_bookmarks_apitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/find_bar_host_browsertest.cc
===================================================================
--- chrome/browser/find_bar_host_browsertest.cc (revision 48638)
+++ chrome/browser/find_bar_host_browsertest.cc (working copy)
@@ -1077,8 +1077,15 @@
EXPECT_EQ(ASCIIToUTF16("page"), GetFindBarTextForBrowser(browser()));
}
+// See http://crbug.com/45594. On Windows, it crashes sometimes.
+#if defined(OS_WIN)
+#define MAYBE_ActivateLinkNavigatesPage DISABLED_ActivateLinkNavigatesPage
+#else
+#define MAYBE_ActivateLinkNavigatesPage ActivateLinkNavigatesPage
+#endif
// This makes sure that dismissing the find bar with kActivateSelection works.
-IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, ActivateLinkNavigatesPage) {
+IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
+ MAYBE_ActivateLinkNavigatesPage) {
HTTPTestServer* server = StartHTTPServer();
ASSERT_TRUE(server);
« no previous file with comments | « chrome/browser/extensions/extension_bookmarks_apitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698