Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2432001: Make Valgrind intercept TCMalloc's tc_{malloc,free,new,delete,..}... (Closed)

Created:
10 years, 6 months ago by Alexander Potapenko
Modified:
9 years, 6 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, willchan no longer on Chromium
Visibility:
Public.

Description

Make Valgrind intercept TCMalloc's tc_{malloc,free,new,delete,..} instead of {malloc,free,new,delete,..} Update the Memcheck/TSan binaries in the SVN. BUG=31951 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48921

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -135 lines) Patch
M binaries/linux_x64/bin/no_op_client_for_valgrind View Binary file 0 comments Download
M binaries/linux_x64/bin/valgrind View Binary file 0 comments Download
M binaries/linux_x64/bin/valgrind-listener View Binary file 0 comments Download
M binaries/linux_x64/bin/valgrind-tsan.sh View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/memcheck-amd64-linux View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/memcheck-x86-linux View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/vgpreload_core-amd64-linux.so View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/vgpreload_core-x86-linux.so View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/vgpreload_memcheck-amd64-linux.so View Binary file 0 comments Download
M binaries/linux_x64/lib/valgrind/vgpreload_memcheck-x86-linux.so View Binary file 0 comments Download
M binaries/linux_x86/bin/no_op_client_for_valgrind View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind-listener View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind-tsan.sh View Binary file 0 comments Download
M binaries/linux_x86/lib/valgrind/memcheck-x86-linux View Binary file 0 comments Download
M binaries/linux_x86/lib/valgrind/vgpreload_core-x86-linux.so View Binary file 0 comments Download
M binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so View Binary file 0 comments Download
M scripts/intercept_tcmalloc.patch View 1 2 2 chunks +64 lines, -135 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alexander Potapenko
10 years, 6 months ago (2010-05-31 14:00:23 UTC) #1
Alexander Potapenko
On 2010/05/31 14:00:23, Alexander Potapenko wrote: > PTAL
10 years, 6 months ago (2010-06-02 13:14:05 UTC) #2
Timur Iskhodzhanov
10 years, 6 months ago (2010-06-04 12:51:12 UTC) #3
LGTM provided you re-test and update the Mac binaries.

Powered by Google App Engine
This is Rietveld 408576698