Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 243118: Alter hooks to call into depot_tools lib.... (Closed)

Created:
11 years, 2 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Alter hooks to call into depot_tools lib. This new method allows us to install pre-cl-upload and pre-cl-dcommit hook files which should rarely need to be updated (with luck). These hooks load the real hooks lib from depot_tools which takes over execution of the presubmit tests. BUG=5339 TEST=hooks are run by git cl upload/dcommit and behave as expected

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -84 lines) Patch
M git-cl-upload-hook View 1 2 2 chunks +4 lines, -54 lines 0 comments Download
A + git_cl_hooks.py View 3 chunks +16 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
chase
11 years, 2 months ago (2009-10-07 00:06:32 UTC) #1
Evan Martin
ok http://codereview.chromium.org/243118/diff/1/3 File git-cl-upload-hook (right): http://codereview.chromium.org/243118/diff/1/3#newcode24 Line 24: # Get arguments from how we were ...
11 years, 2 months ago (2009-10-07 00:09:11 UTC) #2
chase
http://codereview.chromium.org/243118/diff/1/3 File git-cl-upload-hook (right): http://codereview.chromium.org/243118/diff/1/3#newcode24 Line 24: # Get arguments from how we were called. ...
11 years, 2 months ago (2009-10-07 00:12:04 UTC) #3
M-A Ruel
lgtm http://codereview.chromium.org/243118/diff/1/3 File git-cl-upload-hook (right): http://codereview.chromium.org/243118/diff/1/3#newcode21 Line 21: if len(sys.argv) < 2: != ?
11 years, 2 months ago (2009-10-07 00:12:42 UTC) #4
chase
11 years, 2 months ago (2009-10-07 00:15:16 UTC) #5
http://codereview.chromium.org/243118/diff/1/3
File git-cl-upload-hook (right):

http://codereview.chromium.org/243118/diff/1/3#newcode21
Line 21: if len(sys.argv) < 2:
On 2009/10/07 00:12:42, Marc-Antoine Ruel wrote:
> != ?

Done.

Powered by Google App Engine
This is Rietveld 408576698