Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(234)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: base/third_party/icu/README
Issue
243102
:
Convert base dependencies to use sys_string_conversions instead of the ICU... (Closed)
Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: ''
Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
base/base.gyp
base/file_util.cc
base/file_util_posix.cc
base/file_util_unittest.cc
base/file_version_info_mac.mm
base/i18n/icu_string_conversions.h
base/i18n/icu_string_conversions.cc
base/i18n/string_conversions.h
base/i18n/string_conversions.cc
base/json_reader.cc
base/json_writer.cc
base/logging.cc
base/platform_file_posix.cc
base/process_util_mac.mm
base/stats_table.cc
base/string16.cc
base/string16_unittest.cc
base/string_util.h
base/sys_info_posix.cc
base/system_monitor_unittest.cc
base/third_party/icu/README
base/third_party/icu/icu_utf.h
base/third_party/icu/icu_utf.cc
base/trace_event.cc
base/utf_string_conversions.h
base/utf_string_conversions.cc
base/values.cc
chrome/browser/download/download_manager_unittest.cc
View unified diff
|
Download patch
|
Annotate
|
Revision Log
« no previous file with comments
|
« base/system_monitor_unittest.cc
('k') |
base/third_party/icu/icu_utf.h »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
This file has the relevant components from ICU copied to handle basic
2
UTF8/16/32 conversions. Components are copied from utf.h utf8.h utf16.h and
3
utf_impl.c
4
5
The main change is that U_/U8_/U16_ prefixes have been replaced with
6
CBU_/CBU8_/CBU16_ (for "Chrome Base") to avoid confusion with the "real" ICU
7
macros should ICU be in use on the system. For the same reason, the functions
8
and types have been put in the "base_icu" namespace.
OLD
NEW
« no previous file with comments
|
« base/system_monitor_unittest.cc
('k') |
base/third_party/icu/icu_utf.h »
('j') |
no next file with comments »
Issue 243102: Convert base dependencies to use sys_string_conversions instead of the ICU... (Closed)
Created 11 years, 2 months ago by brettw
Modified 9 years, 7 months ago
Reviewers: agl
Base URL: svn://chrome-svn/chrome/trunk/src/
Comments: 3
This is Rietveld
408576698
Chromium Code Reviews
Issue 243102:
Convert base dependencies to use sys_string_conversions instead of the ICU... (Closed)
Base URL: svn://chrome-svn/chrome/trunk/src/