Save/restore position for the preferences window based on prefs....

Save/restore position for the preferences window based on prefs,
from Mingmin Xie <melvinxie@gmail.com>;

BUG=34644
TEST=Try moving the preferences window and confirm it works.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48834

[melvinxie, 2010-06-02 12:50:21]

I register prefs::kPreferencesWindowPlacement in Browser::RegisterPrefs so it
can be used on other platforms too. Is there any better place to do it?

[pink (ping after 24hrs), 2010-06-02 13:11:53]

LGTM with one style nit.

http://codereview.chromium.org/2431004/diff/1/3
File chrome/browser/cocoa/preferences_window_controller.h (right):

http://codereview.chromium.org/2431004/diff/1/3#newcode45
chrome/browser/cocoa/preferences_window_controller.h:45:
scoped_nsobject<WindowSizeAutosaver> size_saver_;
Per obj-C naming, this should be |sizeSaver__|

[melvinxie, 2010-06-02 14:20:41]

Updated per your request. It is "sizeSaver_" now.

On 2010/06/02 13:11:53, pink wrote:
> LGTM with one style nit.
> 
> http://codereview.chromium.org/2431004/diff/1/3
> File chrome/browser/cocoa/preferences_window_controller.h (right):
> 
> http://codereview.chromium.org/2431004/diff/1/3#newcode45
> chrome/browser/cocoa/preferences_window_controller.h:45:
> scoped_nsobject<WindowSizeAutosaver> size_saver_;
> Per obj-C naming, this should be |sizeSaver__|

[tfarina, 2010-06-03 03:40:25]

Have you completed the "Individual Contributor License Agreement"? Also, I can't
see your email at AUTHORS file, could add it to this change list?

[melvinxie, 2010-06-03 03:51:26]

Yes, I completed it. Now I've added AUTHORS into this CL.

On 2010/06/03 03:40:25, tfarina wrote:
> Have you completed the "Individual Contributor License Agreement"? Also, I
can't
> see your email at AUTHORS file, could add it to this change list?

[pink (ping after 24hrs), 2010-06-03 14:17:36]

I'll land this today.

On Wed, Jun 2, 2010 at 11:51 PM,  <melvinxie@gmail.com> wrote:
> Yes, I completed it. Now I've added AUTHORS into this CL.
>
> On 2010/06/03 03:40:25, tfarina wrote:
>>
>> Have you completed the "Individual Contributor License Agreement"? Also, I
>
> can't
>>
>> see your email at AUTHORS file, could add it to this change list?
>
>
>
> http://codereview.chromium.org/2431004/show
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[tfarina, 2010-06-03 14:19:55]

On 2010/06/03 03:51:26, melvinxie wrote:
> Yes, I completed it. Now I've added AUTHORS into this CL.
> 
Thanks!

Now we need to send your patch to the trybots and commit if it passes. (Mike,
Trungluu, I can do this, let me know if you want me to land this patch).

[tfarina, 2010-06-03 14:47:39]

Hi melvinxie, this patch does not apply clearly to ToT, could you sync and
rebase it?

[melvinxie, 2010-06-03 14:55:31]

Now I've synced to the latest and uploaded the CL again.

On 2010/06/03 14:47:39, tfarina wrote:
> Hi melvinxie, this patch does not apply clearly to ToT, could you sync and
> rebase it?

[tfarina, 2010-06-03 15:01:59]

On 2010/06/03 14:55:31, melvinxie wrote:
> Now I've synced to the latest and uploaded the CL again.
> 
Sent to the trybots, see -> http://codereview.chromium.org/2592001/show

[tfarina, 2010-06-03 16:16:27]

Landed in r48834.