Issue 243100: Move nsimage_cache into base so that it can be accessed from outside of chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243100: Move nsimage_cache into base so that it can be accessed from outside of chrome (Closed)

Created:
11 years, 2 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
TVL

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move nsimage_cache into base so that it can be accessed from outside of chrome. This is in support of the next round of rebundling. TEST=does it still build, do the unit tests still pass, does it still work? BUG=14610 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28016

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -113 lines)			Patch
M	base/base.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	base/nsimage_cache_mac.h	View		2 chunks	+11 lines, -5 lines	0 comments	Download
A +	base/nsimage_cache_mac.mm	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_popup_view_mac.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/blocked_popup_container_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_bar_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/bookmark_menu_bridge.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/browser/cocoa/nsimage_cache.h	View		1 chunk	+0 lines, -26 lines	0 comments	Download
D	chrome/browser/cocoa/nsimage_cache.mm	View		1 chunk	+0 lines, -65 lines	0 comments	Download
M	chrome/browser/cocoa/nsimage_cache_unittest.mm	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_controller.mm	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_strip_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/tab_view.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/toolbar_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/web_drag_source.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

I didn't move the unit test, because the unit test depends on Chrome.

11 years, 2 months ago (2009-10-05 18:30:13 UTC) #1

TVL

11 years, 2 months ago (2009-10-05 18:35:27 UTC) #2

lg

http://codereview.chromium.org/243100/diff/1/12
File chrome/browser/cocoa/nsimage_cache_unittest.mm (right):

http://codereview.chromium.org/243100/diff/1/12#newcode14
Line 14: 
can you stick a note in here about the test not living with the code because of
the dependency on the app?

Expand Messages | Collapse Messages