Issue 243022: Clean up code duplication in layout test http_server.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243022: Clean up code duplication in layout test http_server.py (Closed)

Created:
11 years, 2 months ago by Mohamed Mansour

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, Pam (message me for reviews)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Clean up code duplication in layout test http_server. Refactored out UrlIsAlive to live outside the ApacheHttpd class and imported http_utils.py into http_server.py Now they share common code. BUG=6784 TEST=started and stopped http_server successfully. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28351

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove sys path since already imported via bash #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -58 lines)			Patch
	M	tools/python/google/httpd_utils.py	View		2 chunks	+26 lines, -26 lines	0 comments	Download
	M	webkit/tools/layout_tests/layout_package/http_server.py	View	1	3 chunks	+6 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mohamed Mansour

Can you please review, or tell me which person would be best please!

11 years, 2 months ago (2009-10-01 23:15:16 UTC) #2

Lei Zhang

11 years, 2 months ago (2009-10-01 23:23:45 UTC) #3

LGTM, but please test and make sure it works.

http://codereview.chromium.org/243022/diff/1/3
File webkit/tools/layout_tests/layout_package/http_server.py (right):

http://codereview.chromium.org/243022/diff/1/3#newcode22
Line 22: sys.path.append(path_utils.PathFromBase('tools', 'python'))
Not needed. http_server.sh sets $PYTHONPATH correctly.

Expand Messages | Collapse Messages