Issue 2429005: Adds tracking of number of unrenderable textures so...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2429005: Adds tracking of number of unrenderable textures so... (Closed)

Created:
10 years, 6 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Adds tracking of number of unrenderable textures so that we can quickly decide at glDrawXXX time whether or not we have to do more work. TEST=unit tests BUG=42671 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48787

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+183 lines, -75 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	14 chunks	+34 lines, -31 lines	1 comment	Download
M	gpu/command_buffer/service/texture_manager.h	View	5 chunks	+45 lines, -19 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	3 chunks	+60 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View	9 chunks	+44 lines, -23 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

apatrick_chromium

10 years, 6 months ago (2010-06-02 22:20:56 UTC) #2

LGTM

http://codereview.chromium.org/2429005/diff/1/2
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/2429005/diff/1/2#newcode993
gpu/command_buffer/service/gles2_cmd_decoder.cc:993: // Returns true of textures
were set.
of -> if

Expand Messages | Collapse Messages