Refactored Histogram::FactoryGet() to be style-compliant...

Refactored Histogram::FactoryGet() to be style-compliant

Currently, two (2) overloaded versions of Histogram::FactoryGet() exist. Google's C++ style guide discourages such implementations. I refactored the methods into Histogram::FactoryGet() (no name change), which takes 'Sample' types as arguments, and Histogram::FactoryTimeGet(), which takes base::TimeDelta types as arguments.

r = jar


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48766

[Ziad Hatahet, 2010-06-02 18:58:13]

Hi jar,

Could you let me know what you think please?

Cheers,
-- Ziad

[jar (doing other things), 2010-06-02 20:30:59]

LGTM, but please fix the small nit below before landing.

http://codereview.chromium.org/2423004/diff/1/5
File net/disk_cache/histogram_macros.h (right):

http://codereview.chromium.org/2423004/diff/1/5#newcode40
net/disk_cache/histogram_macros.h:40: Histogram::kUmaTargetedHistogramFlag); \
style nit: either indent to match the start of the arg list on teh previous
line, or indent 4 space beyond the start of the previous line.

[Ziad Hatahet, 2010-06-02 20:55:57]

http://codereview.chromium.org/2423004/diff/1/5
File net/disk_cache/histogram_macros.h (right):

http://codereview.chromium.org/2423004/diff/1/5#newcode40
net/disk_cache/histogram_macros.h:40: Histogram::kUmaTargetedHistogramFlag); \
On 2010/06/02 20:30:59, jar wrote:
> style nit: either indent to match the start of the arg list on teh previous
> line, or indent 4 space beyond the start of the previous line.

Done.