Issue 2422: Apply the flags to the SCons environment used to link the library to have the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2422: Apply the flags to the SCons environment used to link the library to have the... (Closed)

Created:
12 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
chromium-reviews_googlegroups.com

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Apply the flags to the SCons environment used to link the library to have the LINKFLAGS take effect. This fixes building shared libraries on 64-bit Linux. Removed the CCFLAGS from the CXXFLAGS for Linux as SCons combines these automatically on Linux. This removed the duplication of flags when compiling on Linux. On Linux SCons defines CXXCOM as follows 'CXXCOM': '$CXX -o $TARGET -c $CXXFLAGS $CCFLAGS $_CCCOMCOM $SOURCES' whereas on Windows it is 'CXXCOM': '$CXX $CXXFLAGS $CCCOMFLAGS' Committed: http://code.google.com/p/v8/source/detail?r=284

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	SConstruct	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages