Git support in presubmit tests....

presubmit_support.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Enables directory-specific presubmit checks to run at upload and/or commit.
 """
 
 __version__ = '1.3.2'
 
@@ skipping 371 matching lines @@
     return ""
 
   def LocalPath(self):
     """Returns the path of this file on the local disk relative to client root.
     """
     return normpath(self._path)
 
   def AbsoluteLocalPath(self):
     """Returns the absolute path of this file on the local disk.
     """
-    return normpath(os.path.join(self._local_root, self.LocalPath()))
+    return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
 
   def IsDirectory(self):
     """Returns true if this object is a directory."""
     if self._is_directory is None:
       path = self.AbsoluteLocalPath()
       self._is_directory = (os.path.exists(path) and
                             os.path.isdir(path))
     return self._is_directory
 
   def Action(self):
@@ skipping 152 matching lines @@
 
   # Matches key/value (or "tag") lines in changelist descriptions.
   _TAG_LINE_RE = re.compile(
       '^\s*(?P<key>[A-Z][A-Z_0-9]*)\s*=\s*(?P<value>.*?)\s*$')
 
   def __init__(self, name, description, local_root, files, issue, patchset):
     if files is None:
       files = []
     self._name = name
     self._full_description = description
-    self._local_root = local_root
+    # Convert root into an absolute path.
+    self._local_root = os.path.abspath(local_root)
     self.issue = issue
     self.patchset = patchset
     self.scm = ''
 
     # From the description text, build up a dictionary of key/value pairs
     # plus the description minus all key/value or "tag" lines.
     self._description_without_tags = []
     self.tags = {}
     for line in self._full_description.splitlines():
       m = self._TAG_LINE_RE.match(line)
@@ skipping 181 matching lines @@
     """Executes a single presubmit script.
 
     Args:
       script_text: The text of the presubmit script.
       presubmit_path: The path to the presubmit file (this will be reported via
         input_api.PresubmitLocalPath()).
 
     Return:
       A list of result objects, empty if no problems.
     """
+
+    # Change to the presubmit file's directory to support local imports.
+    main_path = os.getcwd()
+    os.chdir(os.path.dirname(presubmit_path))
+
+    # Load the presubmit script into context.
     input_api = InputApi(self.change, presubmit_path, self.committing)
     context = {}
     exec script_text in context
 
     # These function names must change if we make substantial changes to
     # the presubmit API that are not backwards compatible.
     if self.committing:
       function_name = 'CheckChangeOnCommit'
     else:
       function_name = 'CheckChangeOnUpload'
     if function_name in context:
       context['__args'] = (input_api, OutputApi())
       result = eval(function_name + '(*__args)', context)
       if not (isinstance(result, types.TupleType) or
               isinstance(result, types.ListType)):
         raise exceptions.RuntimeError(
           'Presubmit functions must return a tuple or list')
       for item in result:
         if not isinstance(item, OutputApi.PresubmitResult):
           raise exceptions.RuntimeError(
             'All presubmit results must be of types derived from '
             'output_api.PresubmitResult')
     else:
       result = ()  # no error since the script doesn't care about current event.
 
+    # Return the process to the original working directory.
+    os.chdir(main_path)
     return result
 
 
 def DoPresubmitChecks(change,
                       committing,
                       verbose,
                       output_stream,
                       input_stream,
                       default_presubmit,
                       may_prompt):
@@ skipping 130 matching lines @@
   options, args = parser.parse_args(argv[1:])
   if not options.root:
     options.root = os.getcwd()
   if os.path.isdir(os.path.join(options.root, '.git')):
     change_class = GitChange
     if not options.files:
       if args:
         options.files = ParseFiles(args, options.recursive)
       else:
         # Grab modified files.
-        raise NotImplementedException()  # TODO(maruel) Implement.
+        options.files = gclient_scm.CaptureGitStatus([options.root])
   elif os.path.isdir(os.path.join(options.root, '.svn')):
     change_class = SvnChange
     if not options.files:
       if args:
         options.files = ParseFiles(args, options.recursive)
       else:
         # Grab modified files.
-        files = gclient_scm.CaptureSVNStatus([options.root])
+        options.files = gclient_scm.CaptureSVNStatus([options.root])
   else:
     # Doesn't seem under source control.
     change_class = Change
   if options.verbose:
-    print "Found %d files." % len(options.files)
+    if len(options.files) != 1:
+      print "Found %d files." % len(options.files)
+    else:
+      print "Found 1 file."
   return not DoPresubmitChecks(change_class(options.name,
                                             options.description,
                                             options.root,
                                             options.files,
                                             options.issue,
                                             options.patchset),
                                options.commit,
                                options.verbose,
                                sys.stdout,
                                sys.stdin,
                                options.default_presubmit,
                                options.may_prompt)
 
 
 if __name__ == '__main__':
   sys.exit(Main(sys.argv))