Git support in presubmit tests....

Git support in presubmit tests.

Expand presubmit_support and gclient_scm to support
getting basic status and changed files from a Git
checkout.

BUG=5339
TEST=presubmit_support.py works from a git checkout,
gcl presubmit works from a svn checkout

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28092

[chase, 2009-10-04 11:02:36]

Here's the presubmit_support.py side of changes for
Git support.  With this patch applied, I can run
presubmit_support.py over a local commit in a Git
checkout from any location in the tree and get the
expected result (such as multiple presubmit scripts
called).

git-cl changes are next, requiring the right hook
scripts besides support for calling and installing
the hooks themselves.

[M-A Ruel, 2009-10-04 20:51:52]

lgtm with some changes.

http://codereview.chromium.org/242140/diff/4001/5002
File gclient_scm.py (right):

http://codereview.chromium.org/242140/diff/4001/5002#newcode19
Line 19: import string
remove

http://codereview.chromium.org/242140/diff/4001/5002#newcode442
Line 442: # SVN utils:
?

http://codereview.chromium.org/242140/diff/4001/5002#newcode467
Line 467: shell=(sys.platform == 'win32'),
use shell=sys.platform.startswith('win')

http://codereview.chromium.org/242140/diff/4001/5002#newcode486
Line 486: status = string.rstrip(CaptureGit(command))
CaptureGit(command).rstrip()

http://codereview.chromium.org/242140/diff/4001/5002#newcode494
Line 494: statuses = [' ' for i in range(7)]
results.append((('%s      ' % m.group(2), file))

seems shorter to me.

[chase, 2009-10-05 01:26:33]

http://codereview.chromium.org/242140/diff/4001/5002
File gclient_scm.py (right):

http://codereview.chromium.org/242140/diff/4001/5002#newcode19
Line 19: import string
On 2009/10/04 20:51:52, Marc-Antoine Ruel wrote:
> remove

Done.

http://codereview.chromium.org/242140/diff/4001/5002#newcode442
Line 442: # SVN utils:
On 2009/10/04 20:51:52, Marc-Antoine Ruel wrote:
> ?

Done.

http://codereview.chromium.org/242140/diff/4001/5002#newcode467
Line 467: shell=(sys.platform == 'win32'),
On 2009/10/04 20:51:52, Marc-Antoine Ruel wrote:
> use shell=sys.platform.startswith('win')

Done.

http://codereview.chromium.org/242140/diff/4001/5002#newcode486
Line 486: status = string.rstrip(CaptureGit(command))
On 2009/10/04 20:51:52, Marc-Antoine Ruel wrote:
> CaptureGit(command).rstrip()

Done.

http://codereview.chromium.org/242140/diff/4001/5002#newcode494
Line 494: statuses = [' ' for i in range(7)]
On 2009/10/04 20:51:52, Marc-Antoine Ruel wrote:
> results.append((('%s      ' % m.group(2), file))
> 
> seems shorter to me.
> 

Done.

[M-A Ruel, 2009-10-06 00:07:50]

lgtm sorry for the delay, ping me next time.