Issue 242124: Follow the spec in disallow function declarations without a name. We...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242124: Follow the spec in disallow function declarations without a name. We... (Closed)

Created:
11 years, 2 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Follow the spec in disallowing function declarations without a name. We used to allow these for compatibility, but both Safari and Firefox now disallow them. Committed: http://code.google.com/p/v8/source/detail?r=3009

Patch Set 1 #

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -50 lines)			Patch
M	src/debug-delay.js	View	9 chunks	+10 lines, -10 lines	1 comment	Download
M	src/parser.cc	View	1 chunk	+12 lines, -23 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/class-of-builtins.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/debug-compile-event.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/mirror-script.js	View	1 chunk	+8 lines, -8 lines	0 comments	Download
M	test/mjsunit/regress/regress-220.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/switch.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

11 years, 2 months ago (2009-10-02 11:30:38 UTC) #2

Lgtm

http://codereview.chromium.org/242124/diff/1/9
File src/debug-delay.js (right):

http://codereview.chromium.org/242124/diff/1/9#newcode351
Line 351: 
Maybe disable trailing whitespace stripping?

Expand Messages | Collapse Messages