Compile without debugger support in debug mode...

Compile without debugger support in debug mode

This makes it possible to build V8 without JavaScript debugging support in debug mode.

BUG=http://code.google.com/p/v8/issues/detail?id=454

Committed: http://code.google.com/p/v8/source/detail?r=2983

[Erik Corry, 2009-09-29 09:01:15]

I don't think this works in this form.

http://codereview.chromium.org/242048/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/242048/diff/1/2#newcode2546
Line 2546: #ifdef ENABLE_DEBUGGER_SUPPORT
Do we need to make the same change for other architectures?

http://codereview.chromium.org/242048/diff/1/3
File src/objects.h (right):

http://codereview.chromium.org/242048/diff/1/3#newcode308
Line 308: INSTANCE_TYPE_LIST_DEBUGGER(V)
I don't think you can do this.  The comments indicate that things that are after
JS_VALUE_TYPE are treated specially by the GC (and perhaps other places) so the
reordering is probably not allowed.

[Søren Thygesen Gjesse, 2009-09-29 09:20:51]

http://codereview.chromium.org/242048/diff/1/2
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/242048/diff/1/2#newcode2546
Line 2546: #ifdef ENABLE_DEBUGGER_SUPPORT
On 2009/09/29 09:01:16, Erik Corry wrote:
> Do we need to make the same change for other architectures?

It is already taken care of in for x64, and for ARM it is not there.

http://codereview.chromium.org/242048/diff/1/3
File src/objects.h (right):

http://codereview.chromium.org/242048/diff/1/3#newcode308
Line 308: INSTANCE_TYPE_LIST_DEBUGGER(V)
On 2009/09/29 09:01:16, Erik Corry wrote:
> I don't think you can do this.  The comments indicate that things that are
after
> JS_VALUE_TYPE are treated specially by the GC (and perhaps other places) so
the
> reordering is probably not allowed.

The ordering refers to the actual enum InstanceType and not the macro which
expands all its values. The macro INSTANCE_TYPE_LIST is currently only used to
collect histograms of the various instance types for dumping GC stats and for
the heap profiler.

[Erik Corry, 2009-09-29 09:23:48]

In that case it LGTM.