Issue 242025: Cleaning up after the initial Chrome Frame commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242025: Cleaning up after the initial Chrome Frame commit.

Created:
11 years, 2 months ago by robertshield

Modified:
11 years, 2 months ago

Reviewers:
amit

CC:
chromium-reviews_googlegroups.com, kuchhal

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Cleaning up after the initial Chrome Frame commit.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+153 lines, -28 lines)			Patch
M	build/common.gypi	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/installer/installer.gyp	View		2 chunks	+2 lines, -12 lines	0 comments	Download
M	chrome/installer/setup/install.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/installer/util/browser_distribution.cc	View		1 chunk	+3 lines, -6 lines	0 comments	Download
A	chrome/installer/util/chrome_frame_distribution.h	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	chrome/installer/util/chrome_frame_distribution.cc	View	1	1 chunk	+88 lines, -0 lines	0 comments	Download
M	chrome_frame/rename_me_to_supplement.gypi	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

amit

11 years, 2 months ago (2009-09-27 17:31:15 UTC) #3

lg

http://codereview.chromium.org/242025/diff/1/3
File build/common.gypi (right):

http://codereview.chromium.org/242025/diff/1/3#newcode237
Line 237: ['experimental_build_define', {
change the comment as well?

Expand Messages | Collapse Messages