Issue 242010: [Mac] Fix depressed baseline in Omnibox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 242010: [Mac] Fix depressed baseline in Omnibox. (Closed)

Created:
11 years, 3 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[Mac] Fix depressed baseline in Omnibox. A previous change converted AutocompleteTextFieldCell to rely more on -drawingRectForBounds: rather than tweaking the baseline in an ad-hoc fashion in many places. This adds a place I missed. http://crbug.com/23096 TEST=Browse to www.google.com. When putting focus in the page the url should stay at the same spot as when focus is in the Omnibox.

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/cocoa/autocomplete_text_field_cell.mm	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

AFAICT, the other uses of -textFrameForFrame: all are internal decoration-drawing code, so should all be ...

11 years, 3 months ago (2009-09-25 20:40:21 UTC) #1

LGTM

Expand Messages | Collapse Messages