Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: build/SConscript.main

Issue 2418: Unignore most warnings on POSIX in build/SConscript.main. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/compiler_specific.h ('k') | skia/SConscript » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/SConscript.main
===================================================================
--- build/SConscript.main (revision 2109)
+++ build/SConscript.main (working copy)
@@ -310,21 +310,10 @@
'webkit',
]
- # TODO: fix code that triggers these warnings.
excluded_warnings = [
- '-Wno-unknown-pragmas', # TODO: remove all the Windows-specific #pragmas.
- '-Wno-unused-function', # TODO: there's just one Skia function.
- '-Wno-unused-variable', # TODO: there's just one v8 function.
- '-Wno-switch', # TODO: this is likely masking real bugs.
- '-Wno-sign-compare', # TODO: this is likely masking real bugs.
- '-Wno-missing-braces', # TODO: just a file in net.
-
- # Not TODO: This is technically nonstandard, but a lot of the image
- # decoding code depends on it and osx wants this.
- '-Wno-multichar',
-
- '-Wno-deprecated', # Needed for using ext/hash_map on GCC 4.3
- '-Wno-reorder', # TODO: many tedious small fixes.
+ # TODO: Clean up uses of ext/hash_map and remove this.
+ # (see unordered_map and base/hash_tables.h)
+ '-Wno-deprecated' # Needed for using ext/hash_map on GCC 4.3
]
env.Replace(
CCFLAGS = ['-m32', '-g', '-pthread'],
« no previous file with comments | « base/compiler_specific.h ('k') | skia/SConscript » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698