Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: webkit/port/bindings/v8/v8_binding.h

Issue 2418: Unignore most warnings on POSIX in build/SConscript.main. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/port/bindings/scripts/CodeGeneratorV8.pm ('k') | webkit/port/platform/TemporaryLinkStubs.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/port/bindings/v8/v8_binding.h
===================================================================
--- webkit/port/bindings/v8/v8_binding.h (revision 2109)
+++ webkit/port/bindings/v8/v8_binding.h (working copy)
@@ -5,6 +5,7 @@
#ifndef V8_BINDING_H__
#define V8_BINDING_H__
+#include "base/compiler_specific.h"
#include "build/build_config.h"
#include <v8.h>
@@ -14,9 +15,9 @@
// Suppress warnings in CString of converting size_t to unsigned int.
// TODO(fqian): fix CString.h.
-#pragma warning(push, 0)
+MSVC_PUSH_WARNING_LEVEL(0);
#include "CString.h"
-#pragma warning(pop)
+MSVC_POP_WARNING();
#if defined(OS_LINUX)
// Use the platform.h for linux.
@@ -133,7 +134,7 @@
// If a WebCore string length is greater than the threshold,
// v8String creates an external string to avoid allocating
// the string in the large object space (which has a high memory overhead).
-static const int kV8ExternalStringThreshold = 2048;
+static const unsigned int kV8ExternalStringThreshold = 2048;
// Convert a string to a V8 string.
inline v8::Handle<v8::String> v8String(const String& str) {
« no previous file with comments | « webkit/port/bindings/scripts/CodeGeneratorV8.pm ('k') | webkit/port/platform/TemporaryLinkStubs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698