Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: build/SConscript.main

Issue 2418: Unignore most warnings on POSIX in build/SConscript.main. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/compiler_specific.h ('k') | skia/SConscript » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import os 5 import os
6 import shutil 6 import shutil
7 import sys 7 import sys
8 8
9 9
10 p = ARGUMENTS.get('PROGRESS') 10 p = ARGUMENTS.get('PROGRESS')
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 'breakpad', 303 'breakpad',
304 'googleurl', 304 'googleurl',
305 'net', 305 'net',
306 'skia', 306 'skia',
307 'testing', 307 'testing',
308 'third_party', 308 'third_party',
309 'v8', 309 'v8',
310 'webkit', 310 'webkit',
311 ] 311 ]
312 312
313 # TODO: fix code that triggers these warnings.
314 excluded_warnings = [ 313 excluded_warnings = [
315 '-Wno-unknown-pragmas', # TODO: remove all the Windows-specific #pragmas. 314 # TODO: Clean up uses of ext/hash_map and remove this.
316 '-Wno-unused-function', # TODO: there's just one Skia function. 315 # (see unordered_map and base/hash_tables.h)
317 '-Wno-unused-variable', # TODO: there's just one v8 function. 316 '-Wno-deprecated' # Needed for using ext/hash_map on GCC 4.3
318 '-Wno-switch', # TODO: this is likely masking real bugs.
319 '-Wno-sign-compare', # TODO: this is likely masking real bugs.
320 '-Wno-missing-braces', # TODO: just a file in net.
321
322 # Not TODO: This is technically nonstandard, but a lot of the image
323 # decoding code depends on it and osx wants this.
324 '-Wno-multichar',
325
326 '-Wno-deprecated', # Needed for using ext/hash_map on GCC 4.3
327 '-Wno-reorder', # TODO: many tedious small fixes.
328 ] 317 ]
329 env.Replace( 318 env.Replace(
330 CCFLAGS = ['-m32', '-g', '-pthread'], 319 CCFLAGS = ['-m32', '-g', '-pthread'],
331 CXXFLAGS = ['-Wall', '-Werror'] + excluded_warnings, 320 CXXFLAGS = ['-Wall', '-Werror'] + excluded_warnings,
332 LINKFLAGS = ['-m32', '-pthread'], 321 LINKFLAGS = ['-m32', '-pthread'],
333 # We need rt for clock_gettime. 322 # We need rt for clock_gettime.
334 LIBS = ['rt'], 323 LIBS = ['rt'],
335 324
336 PERL = '/usr/bin/perl', 325 PERL = '/usr/bin/perl',
337 PERL_INCLUDE_FLAG = '-I ', 326 PERL_INCLUDE_FLAG = '-I ',
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 initial_indent = ' '*32, 534 initial_indent = ' '*32,
546 subsequent_indent = ' '*32, 535 subsequent_indent = ' '*32,
547 ) 536 )
548 components = tw.fill(', '.join(components)) 537 components = tw.fill(', '.join(components))
549 538
550 Help(help_fmt % components) 539 Help(help_fmt % components)
551 540
552 541
553 Import('build_component') 542 Import('build_component')
554 Default(build_component) 543 Default(build_component)
OLDNEW
« no previous file with comments | « base/compiler_specific.h ('k') | skia/SConscript » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698