Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2417007: [Mac] packaging process cleanup: Net of this is the zip off the official buil... (Closed)

Created:
10 years, 6 months ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, kuchhal, pam+watch_chromium.org
Visibility:
Public.

Description

[Mac] packaging process cleanup: Net of this is the zip off the official builder will have everything for packaging so the final signing/dmg creation is self contained instead of having to live in both places. - Move all the installer related bits into the installer folder - Add the collection of these bits into a specific target - Collect the internal bits also during the installer target BUG=42635 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48732

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -866 lines) Patch
M chrome/chrome_exe.gypi View 2 chunks +0 lines, -53 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +76 lines, -0 lines 1 comment Download
A + chrome/installer/mac/app_resource_rules.plist.in View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/mac/keystone_install.sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/mac/make_sign_sh View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/mac/sign.sh.in View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/tools/build/mac/app_resource_rules.plist.in View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/tools/build/mac/keystone_install.sh View 1 chunk +0 lines, -663 lines 0 comments Download
D chrome/tools/build/mac/make_sign_sh View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/tools/build/mac/sign.sh.in View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
TVL
10 years, 6 months ago (2010-06-02 12:53:24 UTC) #1
Mark Mentovai
10 years, 6 months ago (2010-06-02 16:26:14 UTC) #2
LGTM

http://codereview.chromium.org/2417007/diff/1/3
File chrome/chrome_installer.gypi (right):

http://codereview.chromium.org/2417007/diff/1/3#newcode755
chrome/chrome_installer.gypi:755: ['OS=="mac"', {
Self-contained here. Good. I’m not rereading this section, I trust that you took
the existing working bits and glued it all together.

Powered by Google App Engine
This is Rietveld 408576698