Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2417001: Prepare push to trunk. Now working on version 2.2.14. (Closed)

Created:
10 years, 6 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 2.2.14. Committed: http://code.google.com/p/v8/source/detail?r=4755

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M ChangeLog View 1 2 1 chunk +15 lines, -3 lines 0 comments Download
M src/version.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Rico
In addition to the new entries I converted tabs to spaces in ChangeLog for the ...
10 years, 6 months ago (2010-05-31 09:13:18 UTC) #1
Søren Thygesen Gjesse
LGTM http://codereview.chromium.org/2417001/diff/3001/4001 File ChangeLog (right): http://codereview.chromium.org/2417001/diff/3001/4001#newcode8 ChangeLog:8: Add new scons flag --simulatorunalignedaccesses for arm simulator. ...
10 years, 6 months ago (2010-05-31 10:11:28 UTC) #2
Rico
10 years, 6 months ago (2010-05-31 10:13:31 UTC) #3
http://codereview.chromium.org/2417001/diff/3001/4001
File ChangeLog (right):

http://codereview.chromium.org/2417001/diff/3001/4001#newcode8
ChangeLog:8: Add new scons flag --simulatorunalignedaccesses for arm simulator.
On 2010/05/31 10:11:29, Søren Gjesse wrote:
> The flag is ended up being called unalignedaccesses, and is valid for all ARM
> builds - not just with the simulator (sorry I did not update the message).
Also
> flags to SCons are not do not have --'es.

Done.

Powered by Google App Engine
This is Rietveld 408576698