Issue 2409: Set an upper limit to the number of characters that can appear in a tooltip s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2409: Set an upper limit to the number of characters that can appear in a tooltip s... (Closed)

Created:
12 years, 3 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Peter Kasting, sky

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Set an upper limit to the number of characters that can appear in a tooltip string. B=1368905 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=2042

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	chrome/browser/render_widget_host_hwnd.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
	M	chrome/views/tooltip_manager.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

I know I said 1024, but maybe we should just do 256? Either way I'm ...

12 years, 3 months ago (2008-09-10 23:59:39 UTC) #2

Peter Kasting

12 years, 3 months ago (2008-09-11 00:02:35 UTC) #3

On 2008/09/10 23:59:39, sky wrote:
> I know I said 1024, but maybe we should just do 256? Either way I'm fine.

Definitely not 256, some comic site tooltips are routinely longer than that. 
Even 1024 is the lower end of what I'd do.

Expand Messages | Collapse Messages