Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Issue 2408001: More examples at the end of trychange.py help and move the -R flag to the right group (Closed)

Created:
10 years, 6 months ago by M-A Ruel
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

More examples at the end of trychange.py help and move the -R flag to the right group Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48606

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix typo, add epilog to git-try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -21 lines) Patch
M gcl.py View 1 chunk +7 lines, -4 lines 0 comments Download
M git-try View 1 chunk +7 lines, -1 line 0 comments Download
M trychange.py View 1 5 chunks +27 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
Hopefully it'll be clearer for you now. -R has been supported for a year?
10 years, 6 months ago (2010-05-31 00:35:49 UTC) #1
jochen (gone - plz use gerrit)
shouldn't git try have a similar epilog? http://codereview.chromium.org/2408001/diff/1/3 File trychange.py (right): http://codereview.chromium.org/2408001/diff/1/3#newcode462 trychange.py:462: epilog += ...
10 years, 6 months ago (2010-05-31 08:01:39 UTC) #2
Nicolas Sylvain
10 years, 6 months ago (2010-05-31 18:02:14 UTC) #3
lgtm

http://codereview.chromium.org/2408001/diff/1/3
File trychange.py (right):

http://codereview.chromium.org/2408001/diff/1/3#newcode53
trychange.py:53: %(prog)s -R codereview.chromium.org/1337 --email me@example.com
--root src
i dont like : me@example.com .  what about recipient@example.com or something
like that.. (user_to_receive_the_results@example.com)

http://codereview.chromium.org/2408001/diff/1/3#newcode462
trychange.py:462: epilog += eotra_epilog
Oh, and please test the code before committing ;)

Powered by Google App Engine
This is Rietveld 408576698