Issue 2403001: Remove deprecated versions of Registry functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2403001: Remove deprecated versions of Registry functions. (Closed)

Created:
10 years, 6 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
kuchhal, Finnur

CC:
chromium-reviews

Base URL:
git://git.chromium.org/chromium.git

Visibility:
Public.

Description

Remove deprecated versions of Registry functions. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48581

Patch Set 1 : " #

Patch Set 2 : fix typo #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -108 lines)			Patch
M	base/registry.h	View		8 chunks	+45 lines, -93 lines	0 comments	Download
M	chrome/browser/importer/firefox_importer_utils_win.cc	View	1	3 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/importer/ie_importer.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

Rahul is on another project now, so I don't know how responsive he is to ...

10 years, 6 months ago (2010-05-31 00:17:39 UTC) #2

tfarina

10 years, 6 months ago (2010-05-31 01:03:22 UTC) #3

On 2010/05/31 00:17:39, Finnur wrote:
> Rahul is on another project now, so I don't know how responsive he is to
Chrome
> requests anymore. 
> 
Yeah, I see that he is not working more in chromium about some months. But sent
to him, because he wrote the code.

> Therefore, I've reviewed your changelist, but you should know that I *think* I
> saw mirandac take over the browser importing code... You might want to list
her
> as reviewer in the future (for reviews regarding the importer).
>
Sure, I will do. :)

> Thanks for the cleanup!
> 
Thanks for reviewing it.

> LGTM!

Committing now...

Expand Messages | Collapse Messages