Rearrange the code in Scope::ResolveVariable....

Rearrange the code in Scope::ResolveVariable.

I find this clearer and it also enables the DYNAMIC_LOCAL optimization
for code executed by eval that itself uses eval:

 eval("(function() { var x = 2; eval('1'); do stuff with x...; })()")


Committed: http://code.google.com/p/v8/source/detail?r=1322

[Kasper Lund, 2009-02-19 14:56:51]

LGTM.

http://codereview.chromium.org/24023/diff/1/2
File test/mjsunit/local-load-from-eval.js (right):

http://codereview.chromium.org/24023/diff/1/2#newcode38
Line 38: test("(function() { var y = 42; eval('var y = 2'); assertEquals(2, y);
})();");
Maybe you should test that it works when introducing another variable (z?) with
var inside the eval. I'm not quite sure if the eval('var  = 2') in line 38
actually creates an extension object.

[Mads Ager (chromium), 2009-02-19 15:24:52]

> http://codereview.chromium.org/24023/diff/1/2#newcode38
> Line 38: test("(function() { var y = 42; eval('var y = 2'); assertEquals(2,
y);
> })();");
> Maybe you should test that it works when introducing another variable (z?)
with
> var inside the eval. I'm not quite sure if the eval('var  = 2') in line 38
> actually creates an extension object.

Good point.  Done.