Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: chrome/common/debug_flags.cc

Issue 24017: More refactoring of PluginProcessHost (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/debug_flags.h ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/debug_flags.cc
===================================================================
--- chrome/common/debug_flags.cc (revision 9735)
+++ chrome/common/debug_flags.cc (working copy)
@@ -9,7 +9,7 @@
#include "chrome/common/chrome_switches.h"
bool DebugFlags::ProcessDebugFlags(CommandLine* command_line,
- ChildProcessType type,
+ ChildProcessInfo::ProcessType type,
bool is_in_sandbox) {
bool should_help_child = false;
const CommandLine& current_cmd_line = *CommandLine::ForCurrentProcess();
@@ -18,8 +18,10 @@
std::wstring value;
value = current_cmd_line.GetSwitchValue(switches::kDebugChildren);
if (value.empty() ||
- (type == RENDERER && value == switches::kRendererProcess) ||
- (type == PLUGIN && value == switches::kPluginProcess)) {
+ (type == ChildProcessInfo::RENDER_PROCESS &&
+ value == switches::kRendererProcess) ||
+ (type == ChildProcessInfo::PLUGIN_PROCESS &&
+ value == switches::kPluginProcess)) {
command_line->AppendSwitch(switches::kDebugOnStart);
should_help_child = true;
}
@@ -29,8 +31,10 @@
std::wstring value;
value = current_cmd_line.GetSwitchValue(switches::kWaitForDebuggerChildren);
if (value.empty() ||
- (type == RENDERER && value == switches::kRendererProcess) ||
- (type == PLUGIN && value == switches::kPluginProcess)) {
+ (type == ChildProcessInfo::RENDER_PROCESS &&
+ value == switches::kRendererProcess) ||
+ (type == ChildProcessInfo::PLUGIN_PROCESS &&
+ value == switches::kPluginProcess)) {
command_line->AppendSwitch(switches::kWaitForDebugger);
}
command_line->AppendSwitchWithValue(switches::kWaitForDebuggerChildren,
« no previous file with comments | « chrome/common/debug_flags.h ('k') | chrome/test/ui/ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698