Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2542)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_win.cc

Issue 24012: Validate HWNDs that the renderer asks to be moved. (Closed)
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_win.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_win.cc b/chrome/browser/renderer_host/render_widget_host_view_win.cc
index b4996696e22b6a218117fe0e11d9d7a2e64ee3b3..72d0b0a2f6463bd5b376cebf4ef1e4caf89004f9 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_win.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_win.cc
@@ -165,6 +165,13 @@ void RenderWidgetHostViewWin::MovePluginWindows(
if (!::IsWindow(move.window))
continue;
+ // The renderer should only be trying to move windows that are children
+ // of its render widget window.
+ if (::IsChild(m_hWnd, move.window) == 0) {
jam 2009/02/12 19:27:26 If we're doing this check, we don't need the IsWin
+ NOTREACHED();
+ continue;
+ }
+
if (move.visible)
flags |= SWP_SHOWWINDOW;
else
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698