Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 24012: Validate HWNDs that the renderer asks to be moved. (Closed)

Created:
11 years, 10 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
jam, M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Validate HWNDs that the renderer asks to be moved. We make sure any window is a child of the render view window before moving it. BUG=7590

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +7 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Dean McNamee
Make sure I didn't do anything dumb, like use the wrong HWND as the parent. ...
11 years, 10 months ago (2009-02-12 13:36:30 UTC) #1
M-A Ruel
lgtm
11 years, 10 months ago (2009-02-12 13:45:24 UTC) #2
jam
11 years, 10 months ago (2009-02-12 19:27:26 UTC) #3
some comments

in the future, I prefer not to be added as a reviewer unless my comments are
taken care of before commit.

http://codereview.chromium.org/24012/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/24012/diff/1/2#newcode170
Line 170: if (::IsChild(m_hWnd, move.window) == 0) {
If we're doing this check, we don't need the IsWindow above.

nit: I think (IsChild()) is sufficient and more consistent with the rest of the
code than (IsChild() == 0)

Powered by Google App Engine
This is Rietveld 408576698