Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 24011: chrome_resources take 2 (Closed)

Created:
11 years, 10 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Dean McNamee
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Second try of landing chrome_resources project. Changes from last time: - fix scons dependencies by adding a target for grit/theme_resources.h - fix mac build by adding grit to unittest include path - fix check deps by adding rules for /grit dir. Create a chrome_resources.vcproj that holds grd files that hold non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio.

Patch Set 1 #

Patch Set 2 : theme_resources.rc landing take 2 #

Patch Set 3 : upload again #

Patch Set 4 : fix checkdeps #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+643 lines, -890 lines) Patch
M build/all.xcodeproj/project.pbxproj View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/SConscript View 2 chunks +1 line, -1 line 0 comments Download
A chrome/app/chrome_resources.vcproj View 1 chunk +91 lines, -0 lines 0 comments Download
M chrome/app/theme/SConscript View 1 chunk +77 lines, -68 lines 0 comments Download
M chrome/app/theme/distribution_resources.rc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/app/theme/theme_dll.vcproj View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/app/theme/theme_resources.h View 1 chunk +0 lines, -319 lines 0 comments Download
A chrome/app/theme/theme_resources.grd View 1 chunk +330 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources.rc View 1 chunk +0 lines, -307 lines 0 comments Download
M chrome/browser/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_popup.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/base_history_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_folder_tree_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drag_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history_tab_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/browser_resources.vcproj View 1 chunk +0 lines, -89 lines 0 comments Download
chrome/browser/ssl/ssl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/navigation_entry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager_resource_providers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/about_chrome_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/blocked_popup_container.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_started_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/download_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/edit_keyword_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/find_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_customize_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/first_run_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/aero_glass_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/aero_glass_non_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/opaque_non_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/hung_renderer_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/info_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/infobars/infobars.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/keyword_editor_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/views/options/cookies_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/general_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/options/languages_page_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/page_info_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/sad_tab_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/shelf_item_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/star_toggle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/views/tab_icon_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/toolbar_star_toggle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.sln View 6 chunks +10 lines, -2 lines 0 comments Download
M chrome/chrome.xcodeproj/generate_headers.sh View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/chrome.xcodeproj/project.pbxproj View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_kjs.sln View 6 chunks +10 lines, -2 lines 0 comments Download
M chrome/test/automation/automation.vsprops View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/views/custom_frame_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/painter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/views/scroll_view.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/views/text_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/throbber.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/views/tree_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/grit/build/grit_resource_file.bat View 1 chunk +14 lines, -1 line 0 comments Download
M tools/grit/build/grit_resources.rules View 1 chunk +9 lines, -1 line 0 comments Download
M tools/grit/grit/scons.py View 1 2 chunks +10 lines, -0 lines 0 comments Download
M tools/grit/grit/tool/build.py View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tony
11 years, 10 months ago (2009-02-12 17:05:23 UTC) #1
TBR yesterday's change.

Powered by Google App Engine
This is Rietveld 408576698